[Relax][Bugfix] FCallPacked not checked in CodegenVMTIR #17073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tvm-bot rerun |
Member
|
@Lunderberg need rebase |
tqchen
approved these changes
Sep 5, 2024
Prior to this commit, an operator's `FCallPacked` attribute, used to specify a 1:1 mapping between a relax operator and a `PackedFunc` that implements it, was only checked in `CodegenVM`. Any operator with `FCallPacked` would raise an error when compiled using `CodegenVMTIR`. This commit removes the `FCallPacked` handling from `CodegenVM` altogether, and instead checks for this attribute as part of `LegalizeOps`. This provides the same functionality across both backends.
Lunderberg
force-pushed
the
bugfix_fcallpacked_in_codegen_vm_tir
branch
from
fdfd30a to
25d1944
Compare
Contributor
Author
|
Thank you, and rebased to resolve conflicts. (And again to resolve a conflict that wasn't flagged by git.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, an operator's
FCallPackedattribute, used to specify a 1:1 mapping between a relax operator and aPackedFuncthat implements it, was only checked inCodegenVM. Any operator withFCallPackedwould raise an error when compiled usingCodegenVMTIR.This commit removes the
FCallPackedhandling fromCodegenVMaltogether, and instead checks for this attribute as part ofLegalizeOps. This provides the same functionality across both backends.