[TIR] Validate tir::Buffer axis_separators on construction#17219
Merged
quic-sanirudh merged 3 commits intoapache:mainfrom Aug 5, 2024
Merged
Conversation
Prior to this commit, the `axis_separators` field of a TIR buffer wasn't validated until the `tir.FlattenBuffer` legalization pass. Delaying the error until this point makes it difficult to determine where it invalid `axis_separators` were initially defined. This commit updates the `tir::Buffer` constructor to validate the `axis_separators` field immediately, allowing these invalid values to be caught on construction. Closes apache#17215
Contributor
Author
|
And it was definitely good to move the validation, as it exposed an inconsistency in how the metaschedule |
quic-sanirudh
approved these changes
Jul 31, 2024
Contributor
quic-sanirudh
left a comment
quic-sanirudh
left a comment
There was a problem hiding this comment.
LGTM, apart from a small doubt about expected use case.
Lunderberg
deleted the
tir_validate_axis_separators_on_buffer_construction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
axis_separatorsfield of a TIR buffer wasn't validated until thetir.FlattenBufferlegalization pass. Delaying the error until this point makes it difficult to determine where it invalidaxis_separatorswere initially defined.This commit updates the
tir::Bufferconstructor to validate theaxis_separatorsfield immediately, allowing these invalid values to be caught on construction.Closes #17215