[WINDOWS] Compiler options for non x86 targets#17260
Merged
tqchen merged 9 commits intoapache:mainfrom Aug 20, 2024
Merged
Conversation
Windows compiler options for targets
Contributor
Author
|
@srkreddy1238 Can you please look into this PR |
cbalint13
requested changes
Aug 12, 2024
Contributor
cbalint13
left a comment
cbalint13
left a comment
There was a problem hiding this comment.
Thank you @krishnaraj36 for the contribution !
Looks good to me, lets have the assignment logic and the CI lint issue fixed in order to get this merged.
srkreddy1238
approved these changes
Aug 12, 2024
Contributor
srkreddy1238
left a comment
srkreddy1238
left a comment
There was a problem hiding this comment.
LGTM, let the CI pass.
cbalint13
approved these changes
Aug 12, 2024
cbalint13
reviewed
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows compiler options for targets