[Support] Fix the Read/Write of socket stream#17284
Merged
tqchen merged 1 commit intoapache:mainfrom Aug 26, 2024
Merged
Conversation
This PR fixes the `dmlc::Stream::Read/Write` for TCP socket. Given socket does not guarantee that all data are send received/sent in a single shot, we need to use `RecvAll/SendAll`.
MasterJH5574
force-pushed
the
tvm-dev/2024-08-19-socket-recvall-sendall
branch
from
37f9493 to
3a2a861
Compare
tqchen
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
dmlc::Stream::Read/Writefor TCP socket. Given socket does not guarantee that all data are send received/sent in a single shot, we need to useRecvAll/SendAll.