[CI][Hexagon] Forward gtest tests into pytest as separate tests#17334
Merged
Lunderberg merged 2 commits intoapache:mainfrom Sep 5, 2024
Merged
[CI][Hexagon] Forward gtest tests into pytest as separate tests#17334Lunderberg merged 2 commits intoapache:mainfrom
Lunderberg merged 2 commits intoapache:mainfrom
Conversation
Prior to this commit, all Hexagon test cases in `tests/cpp-runtime/hexagon` were executed as part of a single unit test in pytest. This can take a significant portion of the total timeout in CI (~50 minutes out of a 2-hour timeout). While the hexagon tests are split out onto 8 separate runners, having a single large test can cause timeouts on whichever runner happens to receive it. This commit exposes each unit test from `tests/cpp-runtime/hexagon` into a separate unit test in pytest, to avoid these timeouts.
quic-sanirudh
approved these changes
Sep 5, 2024
Contributor
quic-sanirudh
left a comment
quic-sanirudh
left a comment
There was a problem hiding this comment.
Nice idea to use the gtest filter to split these tests. Thanks for this.
Contributor
Author
|
Thank you! It looks like the hexagon tests now have a narrower spread in runtimes across the shards, though there's still some variation (about 1h20m to 1h50m), probably depending on which shard happens to get the long runtime test cases. For now, hopefully this will help avoid having timeouts during CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, all Hexagon test cases in
tests/cpp-runtime/hexagonwere executed as part of a single unit test in pytest. This can take a significant portion of the total timeout in CI (~50 minutes out of a 2-hour timeout). While the hexagon tests are split out onto 8 separate runners, having a single large test can cause timeouts on whichever runner happens to receive it.This commit exposes each unit test from
tests/cpp-runtime/hexagoninto a separate unit test in pytest, to avoid these timeouts.