[RELAX] Fix rotary embedding buffer size calculation#18102
Merged
MasterJH5574 merged 1 commit intoapache:mainfrom Jul 1, 2025
Merged
[RELAX] Fix rotary embedding buffer size calculation#18102MasterJH5574 merged 1 commit intoapache:mainfrom
MasterJH5574 merged 1 commit intoapache:mainfrom
Conversation
Contributor
harrywhoo
commented
Jun 30, 2025
harrywhoo
commented
- Change head_dim//2 to rotary_dim//2 in LongRope scaling
- Fixes buffer size when rotary_dim differs from head_dim when partial_rotary_factor < 1.0
* Change head_dim//2 to rotary_dim//2 in LongRope scaling * Fixes buffer size when rotary_dim differs from head_dim
MasterJH5574
approved these changes
Jul 1, 2025
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
Thanks @harrywhoo for the fix!
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
* Change head_dim//2 to rotary_dim//2 in LongRope scaling * Fixes buffer size when rotary_dim differs from head_dim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.