[Torch] Clean up usage of try ... infer_value() ... except#6504
Merged
masahi merged 5 commits intoapache:masterfrom Sep 22, 2020
Merged
[Torch] Clean up usage of try ... infer_value() ... except#6504masahi merged 5 commits intoapache:masterfrom
masahi merged 5 commits intoapache:masterfrom
Conversation
yongwww
reviewed
Sep 17, 2020
Member
Author
|
@tqchen I got a build error from utvm crt https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-6504/2/pipeline I don't understand why I'm getting an error from a file like |
94f4627 to
e6094fe
Compare
Contributor
Yeah, I'm seeing the same on my PR as well. |
Member
|
@masahi was due to a cmake cache problem that PR has been merged, please retrigger. |
kevinthesun
reviewed
Sep 21, 2020
e6094fe to
9ac55ca
Compare
kevinthesun
reviewed
Sep 21, 2020
Member
Author
|
Thanks @kevinthesun @yongwww |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <masa@pop-os.localdomain>
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <masa@pop-os.localdomain>
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <masa@pop-os.localdomain>
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 19, 2020
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <masa@pop-os.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #6449 where some usage of exception-throwing
infer_valueis introduced. Following the discussion there, I attempted to clean up that usage with a new wrapper API. I think this is a reasonable change to add.The following API is added. If this looks good, I'll add a doc string. See the example use in the Torch frontend.
please review @kevinthesun @t-vi @siju-samuel