[Frontend][ONNX] Support RandomNormal operator#9493
Merged
jwfromm merged 1 commit intoapache:mainfrom Nov 23, 2021
Merged
Conversation
shengxinhu
requested review from
Huyuwei,
Laurawly,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jcf94,
jroesch,
junrushao,
jwfromm,
kazum,
kevinthesun,
masahi,
mbrookhart,
merrymercy,
siju-samuel,
slyubomirsky,
srkreddy1238,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
|
Thanks for contribution! I'm working on upgrading ONNX in our CI. The new version seems to have a few official tests for these operators (even though they've been around since opset 1) which I will run by hopefully by the end of this week. |
jwfromm
approved these changes
Nov 22, 2021
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
This is an excellent change and LGTM. I'm curious what tests you're referring to @AndrewZhaoLuo?
Contributor
|
Huh, you know what, im not sure anymore, looking at this pr: https://github.com/apache/tvm/pull/9519/files, can't seem to find the tests anymore. Must have been mistaken or confused. Go ahead and merge |
Contributor
|
Awesome, thanks for this contribution @shengxinhu! |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support RandomUniformLike, RandomNormal and RandomNormalLike