[TVMSCRIPT] Misc error message improvements#9543
Merged
junrushao merged 3 commits intoapache:mainfrom Dec 3, 2021
Merged
Conversation
tkonolige
requested review from
Hzfengsy,
ZihengJiang,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
zhiics
as code owners
Hzfengsy
approved these changes
Nov 23, 2021
Member
Hzfengsy
left a comment
Hzfengsy
left a comment
There was a problem hiding this comment.
LGTM. Let's merge it when CI is green
tkonolige
force-pushed
the
tvmscript_errormessage_improvements
branch
from
6f1a2c6 to
96a907d
Compare
tkonolige
force-pushed
the
tvmscript_errormessage_improvements
branch
from
96a907d to
e75f13b
Compare
Contributor
Author
|
@Hzfengsy @junrushao1994 CI is green. Can we merge? |
Member
|
Of course! Thanks for improving the error message! |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* [TVMSCRIPT] Misc error message improvements * only prevent indexing into handles with multiple indexes * lint
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
* [TVMSCRIPT] Misc error message improvements * only prevent indexing into handles with multiple indexes * lint
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
* [TVMSCRIPT] Misc error message improvements * only prevent indexing into handles with multiple indexes * lint
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [TVMSCRIPT] Misc error message improvements * only prevent indexing into handles with multiple indexes * lint
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
* [TVMSCRIPT] Misc error message improvements * only prevent indexing into handles with multiple indexes * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of better error messages I've added to the tvmscript parser.