Skip to content

Conversation

@Maxcastel
Copy link
Contributor

Q A
Branch? main
Tickets Closes #..., closes #...
License MIT
Doc PR api-platform/docs#...

@Maxcastel Maxcastel marked this pull request as draft January 28, 2026 11:33
@Maxcastel Maxcastel force-pushed the feature/support-relations-on-filters branch from 056fa57 to fffaa15 Compare January 30, 2026 14:29
@alexislefebvre
Copy link
Contributor

alexislefebvre commented Feb 5, 2026

Does it address #7610?

Update: no, both subjects are about Filters but #7610 is not about relations / joins.

);
}
$alias = $currentAlias;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you move this to a trait? we're using this everywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do a refactor commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 5798e25


foreach ($propertyNames as $property) {
$converted = $this->nameConverter?->denormalize($property) ?? $property;
if (str_contains($property, '.')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't happen right? if you've transformed all the . properties I think we should remove line 213-215 unless I'm missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a real project, and it doesn’t work when I remove lines 213–215.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exemple for: search[products.name]

If I remove lines 213–215, products.name becomes products_Name after denormalization ($converted = $this->nameConverter?->denormalize($property)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass after removing lines 213-215, so maybe there’s a missing test that covers this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test in 910977d

@Maxcastel Maxcastel force-pushed the feature/support-relations-on-filters branch from 2a6baed to 490a9af Compare February 11, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants