ci: Use custom action to commit changes in CI instead of git commit#792
Open
fnesveda wants to merge 1 commit into
Open
ci: Use custom action to commit changes in CI instead of git commit#792fnesveda wants to merge 1 commit into
git commit#792fnesveda wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
t-management
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #792 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 48 48
Lines 4860 4860
=======================================
Hits 4750 4750
Misses 110 110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
changed the title
git commitgit commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to enforce commit signing for all commits in our repositories.
To do that, we need to make sure even commits created by CI workflows are signed.
It would be possible to sign using GPG keys, but that would require a lot of maintenance.
Instead, we can commit using the GitHub GraphQL API, which automatically signs commits.
This PR replaces direct
git commit/git pushusage (and third-party commit actions likeEndBug/add-and-commit)with the
apify/workflows/commitaction, which uses the GraphQL API under the hood.As agreed on Slack, I'm also simplifying the workflows to always work on top of the default branch, rather than on a ref passed down through the input, as it should effectively be the same.