-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
featureIssues that represent new features or improvements to existing features.Issues that represent new features or improvements to existing features.
Description
Which package is the feature request for? If unsure which one to select, leave blank
@crawlee/browser (BrowserCrawler)
Feature
Providing requestHandler is required but IMO it is redundant with what postNavigationHooks are there for. The semantics are IMO also rather confusing, as the function does not handle network requests but rather navigation.
Replace requestHandler(ctx) with new navigationHandler(ctx, gotoOptions) and fix confusing request-handling semantic when navigation-handling is meant.
Thoughts? What can you do in a user defined requestHandler that you cannot do in user defined post navigation hooks?
Motivation
Fix #1631.
Reduce confusion.
Ideal solution or implementation, and any additional constraints
not sure, needs feedback
Alternative solutions or implementations
not sure, needs feedback
Other context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
featureIssues that represent new features or improvements to existing features.Issues that represent new features or improvements to existing features.