Skip to content

fix(sdk): fix issue with sdk response handling #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saeedjamshaid merged 1 commit into from
Aug 1, 2025
Merged

fix(sdk): fix issue with sdk response handling #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions src/infrastructure/services/portal-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,13 @@ export class PortalService {
private handlePortalGenerationErrors = async (error: unknown): Promise<string | NodeJS.ReadableStream> => {
if (error instanceof UnauthorizedResponseError) {
//401
const body = await this.parseErrorResponse(error);
return getMessageInRedColor(body.message ?? "Unauthorized access.");
const unAuthError = error as UnauthorizedResponseError;
return getMessageInRedColor(unAuthError.result?.message ?? "Authorization has been denied for this request.");
} else if (error instanceof ProblemDetailsError) {
//400 & 403
const body = await this.parseErrorResponse(error);
const message = body.errors[Object.keys(body.errors)[0]][0];
return getMessageInRedColor(body.title + "\n- " + message);
const probDetailsError = error as ProblemDetailsError;
const message = (probDetailsError.result!.errors as Record<string, string[]>)?.['']?.[0];
return getMessageInRedColor(probDetailsError.result!.title + "\n- " + message);
} else if (error instanceof ApiError && error.statusCode === 422) {
//422
return error.body as NodeJS.ReadableStream;
Expand Down Expand Up @@ -177,18 +177,13 @@ export class PortalService {
//TODO: Update the spec file to define different error code response types so that they can be handled here. Currently all failures go to the last else statement
if (error instanceof UnauthorizedResponseError) {
//401
const body = await this.parseErrorResponse(error);
return getMessageInRedColor(body.message ?? "Unauthorized access.");
const unAuthError = error as UnauthorizedResponseError;
return getMessageInRedColor(unAuthError.result?.message ?? "Authorization has been denied for this request.");
} else if (error instanceof ProblemDetailsError) {
//400 & 403
const body = await this.parseErrorResponse(error);
const message = body.errors[Object.keys(body.errors)[0]][0];
return getMessageInRedColor(body.title + "\n- " + message);
} else if (error instanceof ApiError && error.statusCode === 422) {
const body = await this.parseErrorResponse(error);
return getMessageInRedColor(
`${body.message}`
);
const probDetailsError = error as ProblemDetailsError;
const message = (probDetailsError.result!.errors as Record<string, string[]>)?.['']?.[0];
return getMessageInRedColor(probDetailsError.result!.title + "\n- " + message);
} else if (error instanceof InternalServerErrorResponseError) {
//500
const body = await this.parseErrorResponse(error);
Expand Down