Skip to content

Apollo Client 3 updates - #241

Closed
hwillson wants to merge 16 commits into
masterfrom
apollo-client-3
Closed

hwillson wants to merge 16 commits into
masterfrom
apollo-client-3

Conversation

@hwillson

Copy link
Copy Markdown
Member

This PR preps apollo-link-rest for the upcoming Apollo Client 3 release. It includes:

  • Wiring in the new @apollo/client package
  • Removing apollo-X packages that are no longer needed
  • Using @apollo/link-X naming for Link dependencies
  • Replacing deprecated function names with their equivalent
  • Removing apollo-link-state references and testing (since apollo-link-state is deprecated and Apollo Client's local state handling is no longer handled through a Link chain)

When Apollo Client 3 is launched, I'll update the @apollo/client and @apollo/link-error dependencies to their final versions. Thanks!

@codecov-io

codecov-io commented Jan 28, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #241   +/-   ##
======================================
  Coverage    92.7%   92.7%           
======================================
  Files           3       3           
  Lines         411     411           
  Branches      123     123           
======================================
  Hits          381     381           
  Misses         28      28           
  Partials        2       2
Impacted Files Coverage Δ
src/restLink.ts 92.46% <ø> (ø) ⬆️
src/utils.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd11e4b...a97e52b. Read the comment docs.

@fbartho fbartho added this to the 0.8.0 milestone Jan 28, 2020
@fbartho

fbartho commented Jan 28, 2020

Copy link
Copy Markdown
Collaborator

Sounds great! When does this have to be shipped by @hwillson? I will adjust the milestone release date, and block some time out at work.

@hwillson

Copy link
Copy Markdown
Member Author

Awesome @fbartho! We're aiming to have @apollo/client final on Feb. 11th. Thanks!

@hwillson

hwillson commented Feb 4, 2020

Copy link
Copy Markdown
Member Author

@fbartho Just a heads up, we're no longer releasing on Feb. 11th. I'll keep you posted on the new release date.

@fbartho

fbartho commented Feb 4, 2020 •

Copy link
Copy Markdown
Collaborator

Thanks for letting me know! I’ll shift the milestone out, for now!

Happy to schedule time when your plans firm up again, @hwillson, just ping me!

@jkjustjoshing

Copy link
Copy Markdown

Would it be possible to release a beta version of this branch to NPM? I'd like to start getting things updated and would love to temporarily point at a beta version until an official release.

@fbartho

fbartho commented Feb 5, 2020

Copy link
Copy Markdown
Collaborator

@jkjustjoshing -- I haven't tested this branch at all. Obviously I assume @hwillson has tested this to some level, but they decided to hold apollo-client-3 for reasons I'm not privy to (but I'd assume it's either issues discovered, or other communication considerations).

Would you still like an alpha build?

@jkjustjoshing

Copy link
Copy Markdown

@fbartho Thanks for emphasizing the pushing out of the Feb 11th date.

It would be useful for socializing the code with my team to have an alpha build, but for now I should be able to use npm link. My app isn't going live until April so I'm ok depending on a pre-release version for now. Thanks!

@fbartho

fbartho commented Feb 5, 2020

Copy link
Copy Markdown
Collaborator

Sounds good! If your needs change, or I don't get the memo that Apollo Client 3 is back on track, please feel free to reach out, as I should be able to carve out time if needed.

@jkjustjoshing

Copy link
Copy Markdown

@fbartho My team has been getting by with building the apollo-client-3 locally and using npm link to run it locally. However, I'm being asked to deploy my app to a dev environment, which npm link won't work for. Would you be able to build and release to NPM a beta release (maybe v0.8.0-beta) of this branch? This would tide me over until Apollo v3 is actually released and this branch can be fully released as v0.8.0.

If the Apollo v3 release is imminent I can wait, but if it'll be any more than a week this will end up being a big blocker for me.

Thanks!

@ajrobertsonio

Copy link
Copy Markdown

We'd love a release build as well, thanks!

@fbartho

fbartho commented Feb 26, 2020

Copy link
Copy Markdown
Collaborator

@jkjustjoshing and @codeithuman -- I'll try to get a Release build out on Friday! -- I have a presentation to prep for to present on Thursday

@ajrobertsonio

ajrobertsonio commented Feb 26, 2020 •

Copy link
Copy Markdown

That sounds wonderful! Thanks for being so responsive @fbartho, we really appreciate it.

@fbartho

fbartho commented Mar 3, 2020

Copy link
Copy Markdown
Collaborator

Looking at getting it tomorrow!

@fbartho

fbartho commented Mar 5, 2020

Copy link
Copy Markdown
Collaborator

Deploying a version later today!

@fbartho fbartho closed this Mar 5, 2020
@fbartho

fbartho commented Mar 5, 2020

Copy link
Copy Markdown
Collaborator

@fbartho
fbartho deleted the apollo-client-3 branch March 5, 2020 01:47
@fbartho

fbartho commented Mar 5, 2020

Copy link
Copy Markdown
Collaborator

Please give us feedback @codeithuman @jkjustjoshing -- as I haven't been able to integrate this into my company's app yet so I haven't been able to use it extensively. We're looking at starting that effort in a month or so.

@nathantqn

Copy link
Copy Markdown

Hi guys, thanks for your contribution, I'm about to use apollo-link-rest and apollo-client 3.0 in my new project, as @hwillson mentioned above When Apollo Client 3 is launched, I'll update the @apollo/client and @apollo/link-error dependencies to their final versions. Thanks!, and finally Apollo Client 3 is launched so I'm not sure whether apollo-link-rest@0.8.0-beta.0 is fully compatible with the latest apollo-client 3.0 version, or I need to wait hwillson to update the packages, could you please help me to confirm this @fbartho, thank you

@vedrani

vedrani commented Mar 12, 2021

Copy link
Copy Markdown

What is the current status of 0.8.0-beta.0? @hwillson @fbartho
Can we help with something?

@fbartho

fbartho commented Mar 12, 2021

Copy link
Copy Markdown
Collaborator

@vedrani -- I've had a few pieces of feedback that the beta works great for folks!

We're on track for integrating it in my company's project in the next month or so (we're not on ApolloClient3 yet), so my plan was to officially ship the release version after that.

If you're already using the beta.0 and it's working for you I have no known issues for you -- so you should feel free to continue using the beta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants