Repository navigation
Add support for AbortController signal passed via context - #296
Open
marioestrada wants to merge 2 commits into
Open
marioestrada wants to merge 2 commits into
marioestrada wants to merge 2 commits into
Conversation
|
@marioestrada: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
marioestrada
force-pushed
the
signal-restlink
branch
from
April 27, 2022 19:07
f258651 to
f1fa6ac
Compare
alexey-svetlenko
approved these changes
Mar 16, 2023
|
Duplicate of #302 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Resolves #251
Description
Adding a good unit test for the abort case was tricky because of the way it's handled in line 1389:
apollo-link-rest/src/restLink.ts
Lines 1388 to 1390 in cde5f56
So I added a unit test using
setTimeoutto test that the request never fulfills, but I know it's not a great pattern to test because it adds an artificial delay to completing the tests.Test
npm test