[jackstudd]

Hi! I quickly spent an hour trying to get this lib to work with Apollo v4 since I need it in some projects.

Of the thousands way this could have been done, I chose one of the quickest and far from cleanest.

I'm just putting this here in case anyone needs it! And if that can help to do a clean update of this lib.

The goal here was just to have the lib work with Apollo v4, have the unit tests green, and be able to build.

[fbartho]

Hey @jackstudd — thanks for the updates!!

I did my first read through, and almost everything seemed reasonable. I don’t have a lot of time to allocate to this project, but if we can address that concern, I can jump through the hoops to get this shipped.

I really appreciate you!

[fbartho]

This combination of lines means that an error is always thrown, and then caught and ignored.

done.fail was setup to tunnel the test failure out — because we were going to expect an error to be thrown.

I think that means this test case is now broken. Any thoughts @jackstudd ?

[fbartho]

@jackstudd I published your changes and some updates to other deps and tests here: https://github.com/apollographql/apollo-link-rest/releases/tag/v0.10.0-rc.1 (and on NPM).

Let me know if you get a chance to verify it, as I am not actively using apollo-link-rest in my current projects.

If I don't hear from anyone in a month or so, I'll hopefully remember to ship this fully as a normal version!