Don't send op headers in introspection from here on out#7732
Don't send op headers in introspection from here on out#7732mayakoneval wants to merge 4 commits intomainfrom
Conversation
…of the embedded Sandbox code
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 30327b3:
|
There was a problem hiding this comment.
It's a bit iffy to hand-modify inline snapshots but can we replace the commit hash with the interpolated constant as well? The tests will pass as the constant changes over time. Unfortunately if the snapshot updates (i.e. html changes for whatever reason) it'll overwrite our interpolated bit but not too worried about it.
Instead of pinning to a commit is there any way we could pin to a major version instead? So like, whenever sandbox is published, overwrite the v1 (or whatever major) in the cdn. It would be nice for AS users to get patches and minors quietly without the need for an AS update to be published.
Needs a changeset.
| await get().expect( | ||
| 200, | ||
| /embeddable-sandbox.cdn.apollographql.com\/_latest\/embeddable-sandbox.umd.production.min.js/s, | ||
| /embeddable-sandbox.cdn.apollographql.com\/17c6b43a4068da710c3713ec72f03dcb34bbd3de\/embeddable-sandbox.umd.production.min.js/s, |
There was a problem hiding this comment.
(my suggestion is missing an import)
| /embeddable-sandbox.cdn.apollographql.com\/17c6b43a4068da710c3713ec72f03dcb34bbd3de\/embeddable-sandbox.umd.production.min.js/s, | |
| new RegExp(`embeddable-sandbox.cdn.apollographql.com\/${DEFAULT_EMBED_VERSION}\/embeddable-sandbox.umd.production.min.js`, 's'), |
The CDN assets are labelled by commit hash right now. We could map version to commit hash somewhere - maybe we can get that from github? Is this a request for now or later 🙏🏻 |
2 participants
We accept this flag in the embedded Sandbox code now, lets set it to false to address #7731
Also pin the most recent commit # on the embeddable Sandbox / Explorer repo so if we need to make a breaking change, we can version apollo/server