fix: setContext missing return statements#154
Closed
scruff311 wants to merge 1 commit intoappium:mainfrom
Closed
Conversation
…statements The setContext function was missing return statements after the await calls in both the Android and iOS branches, causing execution to always fall through to the throw statement — even when the context switch succeeded on the driver. Fixes appium#153
|
Member
|
@scruff311 do you have chance to sign the CLA? |
KazuCocoa
changed the title
SrinivasanTarget
approved these changes
Feb 8, 2026
Author
All set |
Member
|
It looks like the email used for the git commit might be different from what you used to sign the CLA. Could you double check if both email addresses were the same? @scruff311 Feel free to create a new PR to with proper email if needed |
Member
|
1.12.3 includes this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setContextinsrc/command.tsis missingreturnstatements after theawaitcalls in both the Android (isAndroidUiautomator2DriverSession) and iOS (isXCUITestDriverSession) branchesthrow new Error('setContext is not supported'), even when the context switch succeeds on the driverreturnafter eachawait driver.setContext(...)call so the function exits before reaching the throwNote that the sibling functions
getCurrentContextandgetContextsdon't have this issue because they usereturn await, which exits the function.setContextreturnsvoid, so theawaitalone doesn't prevent fall-through.Fixes #153