Fix handling of OctetString in get_options() function#5558
Closed
Nikitosh wants to merge 1 commit intoapple:masterfrom
Nikitosh:fix-octet-string-handling
Closed
Fix handling of OctetString in get_options() function#5558Nikitosh wants to merge 1 commit intoapple:masterfrom Nikitosh:fix-octet-string-handling
Nikitosh wants to merge 1 commit intoapple:masterfrom
Nikitosh:fix-octet-string-handling
Conversation
Collaborator
|
This fix is incomplete - ipp_length() also needs to be updated... |
michaelrsweet
added a commit
that referenced
this pull request
Apr 15, 2019
scheduler/job.c: - get_options(): Correctly encode IPP_TAG_STRING as a quoted string or a hex string depending on the value. - ipp_length(): Handle IPP_TAG_STRING separately.
michaelrsweet
added a commit
that referenced
this pull request
Apr 15, 2019
scheduler/job.c: - get_options(): Handle IPP_TAG_STRING separately and either provide a quoted string or a hex string, depending on the value. - ipp_length(): Handle IPP_TAG_STRING separately.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OctetString option was handled as if they have IPP_TAG_NAME tag, though it stores its data in unknown.data instead of string.text and also stores length instead of '\0' end symbol.