fix(misconf): reject nil plays during playbook parsing#10132
Open
nikpivkin wants to merge 4 commits intoaquasecurity:mainfrom
Open
fix(misconf): reject nil plays during playbook parsing#10132nikpivkin wants to merge 4 commits intoaquasecurity:mainfrom
nikpivkin wants to merge 4 commits intoaquasecurity:mainfrom
Conversation
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
nikpivkin
added
the
autoready
github-actions
bot
removed
the
autoready
| dir: ".", | ||
| expected: []string{"proj1", "proj2"}, | ||
| }, | ||
| { |
There was a problem hiding this comment.
Can I ask a clarifying question regarding this test, and the fix in general:
Will this result in an error for any *.yaml file that doesn't have a valid play, or simply skip/ignore the file?
The context is that I've been testing the Trivy 0.68.2 -> 0.69.0 upgrade in our CI pipelines and we had it fail as described in #10131 for YAML files that are not Ansible playbooks.
Contributor
Author
There was a problem hiding this comment.
The parser simply logs the error when parsing the playbook and skips the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent panic when accessing nil plays by filtering them out during parsing.
Related issues
Checklist