Skip to content

move snackbar error message to utils#678

Merged
itutu-tienday merged 6 commits intodevelop-mainfrom
feature/refactor-yaml-ver-error
Apr 1, 2025
Merged

move snackbar error message to utils#678
itutu-tienday merged 6 commits intodevelop-mainfrom
feature/refactor-yaml-ver-error

Conversation

@milesAraya
Copy link
Copy Markdown
Collaborator

Fix for #629

@milesAraya milesAraya self-assigned this Mar 21, 2025
@milesAraya milesAraya mentioned this pull request Mar 21, 2025
2 tasks
Comment thread frontend/src/store/slice/Pipeline/PipelineTestUtils.ts Outdated
Comment thread frontend/src/store/slice/Pipeline/PipelineUtils.ts
logger.error("You may need to update your workflow yaml file see FAQ")
logger.error("https://github.com/oist/optinist/wiki/FAQ")
logger.error(f"Invalid Workflow yaml param: [{key}]. See {faq_url}")
raise KeyError("Workflow yaml error, see FAQ")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, if a key error occurred here, it would return a 422 error, but in the latest version, doesn't it return a 500 error?
Please recheck the behavior and record the test results.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, I replaced if key not in default_params: on line 18 with if key in default_params: to force it to work (raise KeyError always occurs).

The result of the above seems to be a 500 error.

*If you still can't reproduce the issue, let's review it in detail using screen sharing, etc.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milesAraya
Have you tested any of the following?

  1. RUN ALL
  2. RUN

In the case of 2. RUN, is the snackbar for error 422 displayed properly?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only possible to use RUN ALL when importing a yaml file.

@itutu-tienday itutu-tienday added this to the ver2.0.3 milestone Apr 1, 2025
@milesAraya milesAraya requested a review from itutu-tienday April 1, 2025 05:29
@itutu-tienday itutu-tienday merged commit 629a878 into develop-main Apr 1, 2025
5 checks passed
@milesAraya milesAraya deleted the feature/refactor-yaml-ver-error branch April 11, 2025 01:24
tsuchiyama-araya added a commit that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants