Skip to content

Update run_cluster#859

Merged
milesAraya merged 5 commits intodevelop-mainfrom
feature/run_cluster
Jun 30, 2025
Merged

Update run_cluster#859
milesAraya merged 5 commits intodevelop-mainfrom
feature/run_cluster

Conversation

@milesAraya
Copy link
Copy Markdown
Collaborator

@milesAraya milesAraya commented Jun 24, 2025

Content

Update run_cluster with

  • error handling,
    • Inputs now accept folder path or file path
    • Errors in input cause error message
  • temp dir usage
    • Previously snakemake.yaml file was left remaining in studio folder
  • default flags on
    • use_conda needed to be turned on, however, this should be default

Testcase

Delete any output data folders in /tmp/studio/output/1/tutorial1
run
python run_cluster.py --config=/tmp/studio/output/1/tutorial1/snakemake.yaml


Documentation should be updated to reflect change in flag usage

@milesAraya milesAraya requested a review from itutu-tienday June 24, 2025 03:08
@milesAraya milesAraya self-assigned this Jun 24, 2025
@milesAraya milesAraya linked an issue Jun 24, 2025 that may be closed by this pull request
6 tasks
Comment thread run_cluster.py Outdated
Comment thread run_cluster.py Outdated
@milesAraya milesAraya requested a review from itutu-tienday June 24, 2025 07:44
Copy link
Copy Markdown
Collaborator

@itutu-tienday itutu-tienday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code fix seems OK.
Please adjust the docs afterwards.

Comment thread docs/other/cli_execution.md
Comment thread docs/other/cli_execution.md Outdated
Comment thread docs/other/cli_execution.md
Comment thread docs/other/cli_execution.md Outdated
@milesAraya milesAraya merged commit 19d1b4c into develop-main Jun 30, 2025
5 checks passed
@itutu-tienday itutu-tienday added this to the v2.4.0 milestone Jun 30, 2025
@milesAraya milesAraya deleted the feature/run_cluster branch July 1, 2025 06:25
@itutu-tienday itutu-tienday added the documentation Improvements or additions to documentation label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix run_cluster execution error

2 participants