Use class to support to support Node.js v8.0.0#7
Closed
watilde wants to merge 2 commits intoarchiverjs:masterfrom
Closed
Use class to support to support Node.js v8.0.0#7watilde wants to merge 2 commits intoarchiverjs:masterfrom
watilde wants to merge 2 commits intoarchiverjs:masterfrom
Conversation
watilde
force-pushed
the
feature/use-class
branch
2 times, most recently
from
dafb868 to
4ced4cd
Compare
Author
|
Hmm... TBH, I don't want to drop supporting v6 since it's still active as LTS: https://github.com/nodejs/LTS#lts-schedule1. I will think about the other solution. |
|
Would it be possible for you to publish this change to your npm package please? |
Author
|
@biofractal To fix the issue and keep the backwards compatibility, we need to wait for a patch in the upstream. Once nodejs/node#13370 gets merge, let's try to update again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: archiverjs/node-archiver#236 (comment)