Watchdog trigger changes

[pennam]

I'm opening this PR to have a bit of discussion since i'm not 100% sure of the changes:

• 162049a with the original code the wdog is triggered continously for 10 seconds without delays. Considering a wdog window of 32 seconds i've changed the code in order to kik the wdog each 10 seconds .

• a37d350 since the wdog is triggered only if the callback is configured i think we can safely remove the check on feed_watchdog and always trigger the wdog if the callback is correctly configured in the library. This change will also extend the wdog trigger to all SpiDrv::waitForSlaveReady() calls. I have not experienced any drawback doing this, but propably is too much... if we want to drop this change we need to extend the wdog trig at least to ServerDrv::getClientState since i've seen some wdog resets also in this function.

• 51590db I don't have an explanation for this, but i've noticed that without this delay sometimes the board gets stuck in this while loop, maybe is related to the fact digitalRead is not a real digital read, but is implemented as spi command...

[github-actions]

Memory usage change @ 51590db

Board	flash	%	RAM for global variables	%
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:megaavr:uno2018:mode=on	❔ -54 - +98	-0.11 - +0.2	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	💚 -84 - 0	-0.03 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	💚 -84 - 0	-0.03 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	💚 -84 - 0	-0.03 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/AP_SimpleWebServer flash	%	examples/AP_SimpleWebServer RAM for global variables	%	examples/ConnectNoEncryption flash	%	examples/ConnectNoEncryption RAM for global variables	%	examples/ConnectWithWEP flash	%	examples/ConnectWithWEP RAM for global variables	%	examples/ConnectWithWPA flash	%	examples/ConnectWithWPA RAM for global variables	%	examples/ConnectWithWPA2Enterprise flash	%	examples/ConnectWithWPA2Enterprise RAM for global variables	%	examples/ScanNetworks flash	%	examples/ScanNetworks RAM for global variables	%	examples/ScanNetworksAdvanced flash	%	examples/ScanNetworksAdvanced RAM for global variables	%	examples/SimpleWebServerWiFi flash	%	examples/SimpleWebServerWiFi RAM for global variables	%	examples/Tools/CheckFirmwareVersion flash	%	examples/Tools/CheckFirmwareVersion RAM for global variables	%	examples/Tools/FirmwareUpdater flash	%	examples/Tools/FirmwareUpdater RAM for global variables	%	examples/Tools/SerialNINAPassthrough flash	%	examples/Tools/SerialNINAPassthrough RAM for global variables	%	examples/WiFiChatServer flash	%	examples/WiFiChatServer RAM for global variables	%	examples/WiFiPing flash	%	examples/WiFiPing RAM for global variables	%	examples/WiFiSSLClient flash	%	examples/WiFiSSLClient RAM for global variables	%	examples/WiFiStorage flash	%	examples/WiFiStorage RAM for global variables	%	examples/WiFiUdpNtpClient flash	%	examples/WiFiUdpNtpClient RAM for global variables	%	examples/WiFiUdpSendReceiveString flash	%	examples/WiFiUdpSendReceiveString RAM for global variables	%	examples/WiFiWebClient flash	%	examples/WiFiWebClient RAM for global variables	%	examples/WiFiWebClientRepeating flash	%	examples/WiFiWebClientRepeating RAM for global variables	%	examples/WiFiWebServer flash	%	examples/WiFiWebServer RAM for global variables	%
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:megaavr:uno2018:mode=on	-50	-0.1	0	0.0	98	0.2	0	0.0	98	0.2	0	0.0	98	0.2	0	0.0	98	0.2	0	0.0	58	0.12	0	0.0	58	0.12	0	0.0	-54	-0.11	0	0.0	58	0.12	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-54	-0.11	0	0.0	98	0.2	0	0.0	-46	-0.09	0	0.0	58	0.12	0	0.0	98	0.2	0	0.0	98	0.2	0	0.0	-46	-0.09	0	0.0	-46	-0.09	0	0.0	-54	-0.11	0	0.0
arduino:samd:mkrvidor4000	-80	-0.03	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-20	-0.01	0	0.0	-28	-0.01	0	0.0	-84	-0.03	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-84	-0.03	0	0.0	-40	-0.02	0	0.0	-76	-0.03	0	0.0	0	0.0	0	0.0	-64	-0.02	0	0.0	-64	-0.02	0	0.0	-76	-0.03	0	0.0	-76	-0.03	0	0.0	-84	-0.03	0	0.0
arduino:samd:mkrwifi1010	-80	-0.03	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-20	-0.01	0	0.0	-28	-0.01	0	0.0	-84	-0.03	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-84	-0.03	0	0.0	-40	-0.02	0	0.0	-76	-0.03	0	0.0	0	0.0	0	0.0	-64	-0.02	0	0.0	-64	-0.02	0	0.0	-76	-0.03	0	0.0	-76	-0.03	0	0.0	-84	-0.03	0	0.0
arduino:samd:nano_33_iot	-80	-0.03	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-28	-0.01	0	0.0	-20	-0.01	0	0.0	-28	-0.01	0	0.0	-84	-0.03	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-84	-0.03	0	0.0	-40	-0.02	0	0.0	-76	-0.03	0	0.0	0	0.0	0	0.0	-64	-0.02	0	0.0	-64	-0.02	0	0.0	-76	-0.03	0	0.0	-76	-0.03	0	0.0	-84	-0.03	0	0.0

Click for full report CSV

Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/ConnectWithWPA2Enterprise<br>flash,%,examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/Tools/CheckFirmwareVersion<br>flash,%,examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,examples/Tools/FirmwareUpdater<br>flash,%,examples/Tools/FirmwareUpdater<br>RAM for global variables,%,examples/Tools/SerialNINAPassthrough<br>flash,%,examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiStorage<br>flash,%,examples/WiFiStorage<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018:mode=on,-50,-0.1,0,0.0,98,0.2,0,0.0,98,0.2,0,0.0,98,0.2,0,0.0,98,0.2,0,0.0,58,0.12,0,0.0,58,0.12,0,0.0,-54,-0.11,0,0.0,58,0.12,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-54,-0.11,0,0.0,98,0.2,0,0.0,-46,-0.09,0,0.0,58,0.12,0,0.0,98,0.2,0,0.0,98,0.2,0,0.0,-46,-0.09,0,0.0,-46,-0.09,0,0.0,-54,-0.11,0,0.0
arduino:samd:mkrvidor4000,-80,-0.03,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-20,-0.01,0,0.0,-28,-0.01,0,0.0,-84,-0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-84,-0.03,0,0.0,-40,-0.02,0,0.0,-76,-0.03,0,0.0,0,0.0,0,0.0,-64,-0.02,0,0.0,-64,-0.02,0,0.0,-76,-0.03,0,0.0,-76,-0.03,0,0.0,-84,-0.03,0,0.0
arduino:samd:mkrwifi1010,-80,-0.03,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-20,-0.01,0,0.0,-28,-0.01,0,0.0,-84,-0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-84,-0.03,0,0.0,-40,-0.02,0,0.0,-76,-0.03,0,0.0,0,0.0,0,0.0,-64,-0.02,0,0.0,-64,-0.02,0,0.0,-76,-0.03,0,0.0,-76,-0.03,0,0.0,-84,-0.03,0,0.0
arduino:samd:nano_33_iot,-80,-0.03,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-28,-0.01,0,0.0,-20,-0.01,0,0.0,-28,-0.01,0,0.0,-84,-0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-84,-0.03,0,0.0,-40,-0.02,0,0.0,-76,-0.03,0,0.0,0,0.0,0,0.0,-64,-0.02,0,0.0,-64,-0.02,0,0.0,-76,-0.03,0,0.0,-76,-0.03,0,0.0,-84,-0.03,0,0.0

[aentinger]

Okay, I see your point. However, can't it be written in a simplified way without needing to cast to int32_t? Something along the lines of

unsigned long start = millis();
/* ... */
if(feed_watchdog)
{
  unsigned long const now = millis();  
  if(now - start > 10000)
  {
    WiFi.feedWatchdog();
    start = now;
  }
}

?
Also feed_watchdog is there for purpose, only the BearSSL offloaded SSL calls take longe enough to warrant feeding the watchdog outside of update().