How dow you suggest changes for default config templates?

[wayner9]

For the default template for the Sonoff THR320D, GPIO 15 is set for Led_Link_i. I think it should be Led_Link. This way the Wifi LED stays on when you have a valid Wifi connection, which is presumably the desired action. How do you suggest this change so that the default template on Blakadder, or other places, is corrected for the benefit of others in the future?

[barbudor]

You need to create a PR on https://github.com/blakadder/templates
Specifically the file for Sonoff THR320D is there: https://github.com/blakadder/templates/blob/cb208ab402a0c22f27f021bd574e183261f64616/_templates/sonoff_THR320D#L4

[wayner9]

What's a PR?

[barbudor]

A Pull Request
It is a process in Github to suggest changes on a file
You need to:

• Fork the "templates" repository => that will make a copy in your own account
  go to: https://github.com/blakadder/templates
  on top of page, click on "Fork"
  

• In your copy, go to the same file. Should be https://github.com/wayner9/templates/blob/master/_templates/sonoff_THR320D

• Use the pencil button to make the change
  

• Save using the "Commit changes..." button
  

• Then you will be proposed to create a Pull Request

[wayner9]

Ok, thanks. This stuff is confusing when doing it for the first time.

[sfromis]

Each template page already has an edit link, to the right, for Github page with the device. This route will automatically fork when you edit, and generally have simpler steps, directly available on each page you get to.

[wayner9]

Thanks, I had never done this before but now I have submitted the change via a Pull Request. But when I click on Pull Request from the link at the top of this page I don't see it under the list of Pull Requests.

[sfromis]

Clicking "Pull Requests" is to see if someone else has been submitting a PR for you to deal with. It does not look like you actually submitted a PR to https://github.com/blakadder/templates/pulls and your commit blakadder/templates@master...wayner9:templates:master still has a button for "Create pull request".

Anyway, while your change may reflect your preference for how you like the led to work, this may not be a presumption for users in general. It's the type of thing where there is no "correct" of led behavior. However, I have no strong opinion either way. 😄