Repository navigation
Refactor JPEG size retrieval function - #25226
Merged
Merged
Conversation
Refactor get_jpeg_size function to improve JPEG parsing and validation.
Collaborator
Author
|
@arendst Should be good to be merged. Tested with several jpeg files. |
Collaborator
|
I submitted an AI review, and it proposed some improvements:
Do you want me to update the files in place in this PR? |
Collaborator
Author
|
@s-hadinger i added the USE_BERRY_IMAGE since the jpeg size refactor is part of implementation of a new epd display. Not complete jpeg is an error and should not be accepted. |
Collaborator
|
Ok, let me fix that |
Collaborator
|
Wait, let me clean up my mess |
s-hadinger
force-pushed
the
support_jpeg
branch
from
November 5, 2026 13:19
42b6242 to
6048f9f
Compare
Collaborator
|
Ok, I just limited to zeroing the height/width when the JPEG is rejected. |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactor get_jpeg_size function to improve JPEG parsing and validation.
Related (if applicable): #25219 @SHIFox8
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass