Ensure that rounded capacity is non-zero in resampleBuffer.#295
Merged
ZachNagengast merged 1 commit intoargmaxinc:mainfrom Jan 22, 2025
Merged
Ensure that rounded capacity is non-zero in resampleBuffer.#295ZachNagengast merged 1 commit intoargmaxinc:mainfrom
ZachNagengast merged 1 commit intoargmaxinc:mainfrom
Conversation
Round off in resampling can lead to a rounded capacity of zero, causing AVAudioPCMBuffer to fail, and thereby causing transcription to fail entirely. (argmaxinc#224) This is a simple fix, simply requiring the buffer to have a non-zero capacity.
Contributor
ZachNagengast
left a comment
ZachNagengast
left a comment
There was a problem hiding this comment.
Simple PR, looks good. Do you have any reproducible way to create this issue so we can test its working?
ZachNagengast
approved these changes
Jan 22, 2025
|
Hi @ZachNagengast can you release a new version of WhisperKit with this fix please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round off in resampling can lead to a rounded capacity of zero, causing AVAudioPCMBuffer to fail, and thereby causing transcription to fail entirely. (#224)
This is a simple fix, simply requiring the buffer to have a non-zero capacity.