Backport BNNSScalar and MLShapedArrayScalar conformances of Float16 for older OS versions in Swift 6#405
Merged
ZachNagengast merged 1 commit intoargmaxinc:swift-6from Jan 27, 2026
Conversation
…er OS versions in Swift 6
There was a problem hiding this comment.
Pull request overview
This pull request updates the Float16 protocol conformances for BNNSScalar and MLShapedArrayScalar to be compatible with Swift 6 while preventing symbol conflicts with Apple's official implementations on newer OS versions.
Changes:
- Added
@retroactiveannotations to Float16 extensions for Swift 6 compatibility - Implemented platform-specific availability with
@available(obsoleted:)to prevent conflicts with Apple's conformances - Separated macOS and Mac Catalyst conformances with proper compiler directives
- Added explicit implementations of required protocol properties (
bnnsDataTypeandmultiArrayDataType)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
naykutguven
changed the title
ZachNagengast
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an availability-gated backport of Apple’s Float16 conformances for older OS versions, avoiding duplicate conformance on newer OS and compiling cleanly under Swift 6.
Platform-specific protocol conformance improvements:
@available(..., obsoleted: ...)annotations to theFloat16extensions forBNNSScalarandMLShapedArrayScalaron macOS and Mac Catalyst, ensuring these conformances are only available on supported OS versions and not visible on newer versions. The official conformances ofFloat16implemented by Apple are available on macOS 26+ and macOS 15+, respectively.