fix(makefile): Improve performance of make lint-local and dependent goals#26025
Merged
reggie-k merged 1 commit intoargoproj:masterfrom Jan 18, 2026
Merged
fix(makefile): Improve performance of make lint-local and dependent goals#26025reggie-k merged 1 commit intoargoproj:masterfrom
reggie-k merged 1 commit intoargoproj:masterfrom
Conversation
…oals Signed-off-by: Oliver Gondža <ogondza@gmail.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
nitishfy
previously requested changes
Jan 16, 2026
Member
nitishfy
left a comment
nitishfy
left a comment
There was a problem hiding this comment.
Should we do the same for gitops-engine/Makefile too?
Contributor
Author
That Makefile is not using any of the vars, so this in fact brings them in sync. |
reggie-k
approved these changes
Jan 18, 2026
reggie-k
dismissed
nitishfy’s stale review
The question was answered by the author.
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, the lint time shrunk form 4 minutes to 50 seconds* on my workstation making
lintandpre-commitmuch practical to use. It is a combined effect of dropping both those options.Based on my code archeology, the options and their values were last tweaked 6+ years ago[1][2], presumably to please now unused Circle CI.
So unless @jannfis or @alexmt object, I would like to simplify and speed things up.
[1] 75d9f23
[2] 949518e
*) measured as
golangci-lint cache clean && make lint-local