Skip to content

Update Rust to 1.78.0#424

Merged
sksat (sksat) merged 1 commit into
mainfrom
feature/update-rust-1.78
Mar 12, 2025
Merged

Update Rust to 1.78.0#424
sksat (sksat) merged 1 commit into
mainfrom
feature/update-rust-1.78

Conversation

@sksat
Copy link
Copy Markdown
Member

  • Rust 1.83.0 から、lockfile v4 が default になった
  • ところで、Renovate が依存を更新する時は、内部で cargo update が叩かれている
    • そして、(おそらく)Renovate のコンテナが抱えている Rust のバージョンで更新が行われる
    • Cargo.lock が v4 になった状態で commit される
  • しかし、lockfile v4 は 1.78.0 で stabilize された
    • ということは、Rust 1.77.0 以前では v4 な Cargo.lockが発生するとビルドがコケる
  • そのため、一旦 1.78.0 に上げる

@sksat sksat (sksat) requested a review from Copilot March 12, 2025 02:18
@sksat sksat (sksat) self-assigned this Mar 12, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Rust toolchain version to 1.78.0 to ensure compatibility with Cargo.lock v4 generated by Renovate.

  • Updated the Rust channel in rust-toolchain.toml from 1.76.0 to 1.78.0
  • Ensures that build environments using Rust prior to 1.78.0 no longer encounter issues with lockfile v4

Copy link
Copy Markdown
Member

@ymgyt Yuta Yamaguchi (ymgyt) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です

@sksat sksat (sksat) merged commit 88fe62b into main Mar 12, 2025
@sksat sksat (sksat) deleted the feature/update-rust-1.78 branch March 12, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants