Update Dependencies #2
Open
+181
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to handle the change in semantics of `race` now that we've updated our cats-effect version.
valencik
commented
Dec 3, 2025
| case Outcome.Succeeded(fa) => | ||
| fa.flatMap { | ||
| case Some(a) => f.cancel.as(Some(a)) | ||
| case None => |
Author
There was a problem hiding this comment.
We won the race, but we decided to "forfeit" so we have to look to the loser to decide what to do.
| } | ||
| case Outcome.Errored(e) => f.cancel *> F.raiseError(e) | ||
| case Outcome.Canceled() => | ||
| f.cancel *> f.join.flatMap { |
Author
There was a problem hiding this comment.
We copy the new semantics of race here because we are no longer using self-cancelation for anything meaningful, instead we use None to signal "forfeiting".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all huckle's dependencies.
Most consequential is updating cats-effect past 3.5.0 which introduced a breaking semantic change in
racewhich huckle relied.This manifested in flakey test failures noted by the angry ❌ in my commit statuses.
For more context, the PR introducing the change: typelevel/cats-effect#3453
For even more context, we can see a certain someone predicting that this code would break here: typelevel/cats-effect#3396 (comment)
Arman and I chatted about a more user friendly API that allows for "forfeiting", a possible
raceOptionwhere the firstSomewins andNonecan be used toforfeitthe race.I have attempted to write this combinator in utils.scala and have used it in
resolve.In my testing, I cannot get the tests to flake anymore.