Skip to content

Comments

feat: Add SESSION_DOMAIN env var#48

Open
asetty wants to merge 1 commit intoarrikto:masterfrom
asetty:feat-session-domain
Open

feat: Add SESSION_DOMAIN env var#48
asetty wants to merge 1 commit intoarrikto:masterfrom
asetty:feat-session-domain

Conversation

@asetty
Copy link
Contributor

@asetty asetty commented Oct 15, 2020

Allow the user to customize the Domain attribute for user
session / cookie.

By default the value is "" and will default to the URL used by the
oidc provider when making the request to the callback.

Signed-off-by: Adam Setters asetty@arista.com

Allow the user to customize the Domain attribute for user
session / cookie.

By default the value is "" and will default to the URL used by the
oidc provider when making the request to the callback.

Signed-off-by: Adam Setters <asetty@arista.com>
@asetty
Copy link
Contributor Author

asetty commented Oct 19, 2020

@yanniszark could you take a look at this?

Also heads up, I'll be sending a PR to add functionality to include the scheme and host for the origURL state sometime this week.

@yanniszark
Copy link
Contributor

yanniszark commented Oct 21, 2020

@asetty thanks for the PR and sorry for the wait.
I'm rather busy with Kubecon these days.
I would feel much more comfortable approving changes if we had an issue outlining what the general plan is. This PR seems like it's part of a bigger plan.
Can you summarize the current state, the problem and the proposed solution in #43?
Please help me see the bigger picture :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants