Skip to content

Conversation

@OriolAbril
Copy link
Member

Review and update contributing pages after the refactor.

```

5. Project requirements are defined in pyproject.toml. Libraries used for development and documentation are provided as optional dependency groups. To set up a development environment, you may (probably in a [virtual environment](https://docs.python-guide.org/dev/virtualenvs/)) run:
5. We use [tox](https://tox.wiki/en/latest/index.html) to help with common development tasks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the recommendation to first create a virtual environment? Not sure if this is mandatory, but I've found it helpful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean to install tox in a dedicated virtual environment? It is a python library but I see it partially as pixi or conda too. It will create the different virtualenvs for each task. It could be different projects using tox might need different tox versions to work but I am not sure how worth is keeping the advice given the current workflow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean to install tox in a dedicated virtual environment?

Yes, but in this exact time I'm also realizing it may not be needed. I've been doing it because I've been following this to literally.

So, let's continue without the virtual environment creation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have those be links to the updated contributing guide at some point

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@tomicapretto
Copy link
Contributor

Everything looks great, only leaving small comments

@OriolAbril OriolAbril merged commit c9a63bb into arviz-devs:main Feb 4, 2026
4 checks passed
@OriolAbril OriolAbril deleted the contributing-how-to branch February 4, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants