Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #403
As far as I can tell, there isn't a better way of normalizing mouse wheel deltas across various platforms than coming up with some "good enough" magic values, so that's what I've done.
Currently, wasm builds running in Firefox/Chrome on both Windows and Linux have this zoom bug that results in zoom-in resulting in the camera zooming all the way in, and zoom out resulting in much larger steps than desktop. Mac OS + trackpad seems to work fine.
I've adjusted the scroll delta from PixelDelta events (from wasm) to be much closer to the LineDelta events (from desktop) and now zooming on web behaves much better across all the platforms I've mentioned.
I've also included patches to make zooming in and out symmetric (previously zoom in then out would not return to original zoom level).