[Bug]: `//lint/clang_tidy.bzl` refers to `CcInfo`, removed from Bazel 9

[jashank]

What happened?

As with #810: @aspect_rules_lint//lint/clang_tidy.bzl itself refers to CcInfo at

rules_lint/lint/clang_tidy.bzl

Lines 379 to 387 in a0aa91f

	if not CcInfo in target:
	return []
	files_to_lint = _filter_srcs(ctx.rule)
	compilation_context = target[CcInfo].compilation_context
	if hasattr(ctx.rule.attr, "implementation_deps"):
	compilation_context = cc_common.merge_compilation_contexts(
	compilation_contexts = [compilation_context] +
	[implementation_dep[CcInfo].compilation_context for implementation_dep in ctx.rule.attr.implementation_deps],

:

(18:53:54) ERROR: /var/obj/_bazel_jashank/7a23896fd80f37b91bcc9ce88059a418/external/aspect_rules_lint+/lint/clang_tidy.bzl:379:12: The CcInfo symbol has been removed, add the following to your BUILD/bzl file:

load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
(18:53:54) ERROR: /var/obj/_bazel_jashank/7a23896fd80f37b91bcc9ce88059a418/external/aspect_rules_lint+/lint/clang_tidy.bzl:383:34: The CcInfo symbol has been removed, add the following to your BUILD/bzl file:

load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
(18:53:54) ERROR: /var/obj/_bazel_jashank/7a23896fd80f37b91bcc9ce88059a418/external/aspect_rules_lint+/lint/clang_tidy.bzl:387:56: The CcInfo symbol has been removed, add the following to your BUILD/bzl file:

load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")

I suspect that adding the suggested load line would fix this.

Version

Development (host) and target OS/architectures:

Output of bazel --version:

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

Language(s) and/or frameworks involved:

How to reproduce

Any other information?

No response

[jashank]

Turns out, I was correctly pessimistic: if I patch the relevant load into //lint/clang_tidy.bzl (and make rules_cc, at version 0.2.17, visible) I get two new explosion, for each of cc_library and cc_binary:

(21:01:25) ERROR: .../lm/BUILD.bazel:34:11: in //utils/lint:linters.bzl%clang_tidy aspect on cc_library rule //lm:lm: 
Traceback (most recent call last):
	File "/var/obj/_bazel_jashank/7a23896fd80f37b91bcc9ce88059a418/external/aspect_rules_lint+/lint/clang_tidy.bzl", line 386, column 40, in _clang_tidy_aspect_impl
		compilation_context = cc_common.merge_compilation_contexts(
Error: 'struct' value has no field or method 'merge_compilation_contexts'
Available attributes: action_is_enabled, add_go_exec_groups_to_binary_rules, check_experimental_cc_shared_library, do_not_use_tools_cpp_compiler_present, empty_variables, get_environment_variables, get_execution_requirements, get_memory_inefficient_command_line, get_tool_for_action, get_tool_requirement_for_action, implementation_deps_allowed_by_allowlist, incompatible_disable_objc_library_transition, internal_DO_NOT_USE, legacy_cc_flags_make_variable_do_not_use

(21:01:25) ERROR: .../lmbin/BUILD.bazel:41:10: in //utils/lint:linters.bzl%clang_tidy aspect on cc_binary rule //lmbin:arpa2fst: 
Traceback (most recent call last):
	File "/var/obj/_bazel_jashank/7a23896fd80f37b91bcc9ce88059a418/external/aspect_rules_lint+/lint/clang_tidy.bzl", line 402, column 26, in _clang_tidy_aspect_impl
		clang_tidy_action(
	File "/var/obj/_bazel_jashank/7a23896fd80f37b91bcc9ce88059a418/external/aspect_rules_lint+/lint/clang_tidy.bzl", line 327, column 39, in clang_tidy_action
		compiler_args = _get_compiler_args(ctx, compilation_context, srcs)
	File "/var/obj/_bazel_jashank/7a23896fd80f37b91bcc9ce88059a418/external/aspect_rules_lint+/lint/clang_tidy.bzl", line 282, column 54, in _get_compiler_args
		args.extend(_safe_flags(ctx, _toolchain_flags(ctx, user_flags, ACTION_NAMES.cpp_compile) + rule_flags) + ["-xc++"])
	File "/var/obj/_bazel_jashank/7a23896fd80f37b91bcc9ce88059a418/external/aspect_rules_lint+/lint/clang_tidy.bzl", line 83, column 38, in _toolchain_flags
		feature_configuration = cc_common.configure_features(
Error: 'struct' value has no field or method 'configure_features'
Available attributes: action_is_enabled, add_go_exec_groups_to_binary_rules, check_experimental_cc_shared_library, do_not_use_tools_cpp_compiler_present, empty_variables, get_environment_variables, get_execution_requirements, get_memory_inefficient_command_line, get_tool_for_action, get_tool_requirement_for_action, implementation_deps_allowed_by_allowlist, incompatible_disable_objc_library_transition, internal_DO_NOT_USE, legacy_cc_flags_make_variable_do_not_use

I don't know enough about the innards of the Starlarkified cc_* rules (and haven't much time or enthusiasm to dig in) so I cannot say I really know what's gone sideways here.