Allow OWIN hosts and applications to register default ICookieManager instances#486
Merged
Tratcher merged 1 commit intoaspnet:mainfrom Dec 16, 2022
Merged
Conversation
kevinchalet
commented
Dec 15, 2022
kevinchalet
commented
Dec 15, 2022
kevinchalet
commented
Dec 15, 2022
kevinchalet
force-pushed
the
default_cookie_manager
branch
2 times, most recently
from
962bd1e to
4061b1b
Compare
Tratcher
approved these changes
Dec 15, 2022
|
|
||
| if (manager is null) | ||
| { | ||
| app.Properties.Remove("infrastructure.CookieManager"); |
Member
There was a problem hiding this comment.
Use constants for the key names.
Contributor
Author
There was a problem hiding this comment.
Done. I also updated the title to better reflect that these extensions can also be used by applications (and not just hosts) to override the default cookie managers.
kevinchalet
force-pushed
the
default_cookie_manager
branch
from
20aadab to
1d84906
Compare
kevinchalet
changed the title
kevinchalet
force-pushed
the
default_cookie_manager
branch
from
1d84906 to
e863f3a
Compare
Contributor
Author
|
Looks like the |
Member
|
Thanks |
Member
|
I probably won't ship this right away, more likely in January. Try the nightly builds? |
Contributor
Author
|
I will 😃 (I tested with the sandbox app when preparing this PR and the SystemWeb cookie manager was correctly resolved) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #485.
/cc @Tratcher