Skip to content

Implements Virtualization overhead modelling#357

Merged
DanteNiewenhuis merged 11 commits into
atlarge-research:masterfrom
noleu:feat/virtualization-overhead
Jul 15, 2025
Merged

Implements Virtualization overhead modelling#357
DanteNiewenhuis merged 11 commits into
atlarge-research:masterfrom
noleu:feat/virtualization-overhead

Conversation

@noleu

@noleu noleu commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

** This PR depends on the PR 355 **

Summary

Implements performance degradation through virtualization for GPUs. Offers 3 different models, No virtualization overhead as the default, Constant performance degradation, with an optionally customizable percentage overhead. And a share based overhead, proportionally to the number of consumer attached to the GPU.

Implementation Notes ⚒️

  • Extension of the TopologyJsonSpec
  • Factory to match Enum to class that implements the VirtualizationOverheadModel interface
  • GPU obtains supply via the VirtualizationOverheadModel interface
  • 3 different implementation of the interface

External Dependencies 🍀

  • N/A

Breaking API Changes ⚠️

  • New optional field in topology for GPU
  • GPU does not calculate supply directly anymore

Simply specify none (N/A) if not applicable.

@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 69.23077% with 28 lines in your changes missing coverage. Please review.

Project coverage is 63.02%. Comparing base (a5f3c19) to head (7904fca).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...org/opendc/compute/topology/specs/TopologySpecs.kt 57.69% 6 Missing and 5 partials ⚠️
.../java/org/opendc/simulator/compute/gpu/SimGpu.java 50.00% 7 Missing and 1 partial ⚠️
...ualization/VirtualizationOverheadModelFactory.java 75.00% 3 Missing and 2 partials ⚠️
.../org/opendc/simulator/compute/models/GpuModel.java 66.66% 2 Missing ⚠️
...n/org/opendc/compute/topology/TopologyFactories.kt 50.00% 0 Missing and 1 partial ⚠️
...va/org/opendc/simulator/engine/graph/FlowEdge.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #357      +/-   ##
============================================
+ Coverage     63.00%   63.02%   +0.01%     
  Complexity       51       51              
============================================
  Files           357      361       +4     
  Lines         12560    12642      +82     
  Branches       1307     1317      +10     
============================================
+ Hits           7914     7968      +54     
- Misses         4192     4210      +18     
- Partials        454      464      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

noleu added 11 commits July 15, 2025 15:57
Extends the Parquet export functionality to support an arbitrary number of GPUs.
This change introduces a new function `withGpuColumns` to `ComputeExportConfig`
that dynamically generates the necessary export columns based on the number of GPUs.
The existing hardcoded GPU columns are replaced by a new `gpuColumns` function
that generates a set of export columns based on the index of the GPU.

This enhancement allows users to collect detailed telemetry data for each GPU
present in the simulated environment, improving the accuracy and granularity
of performance analysis.
Refactors the GPU statistics reporting mechanism to provide a single, aggregated view instead of a list of individual statistics.
This change simplifies data access and reduces complexity in downstream processing, allowing for clearer and more efficient analysis of GPU usage.
The task export columns are updated to reflect this change.
Changes the flow distribution mechanism to leverage a factory for creating distributors based on specified policies.

This enhances modularity and allows for easy switching between different distribution strategies (e.g., MaxMinFairness, FixedShare) without modifying core components.

The previous implementation used a hardcoded `FlowDistributor` and now uses `FlowDistributorFactory` to obtain the distributor based on the specified distribution policy.
This commit introduces configurable flow distribution policies for CPU and GPU resources within the OpenDC compute topology.

It allows users to specify different distribution strategies, such as MAX_MIN_FAIRNESS, EQUAL_SHARE, and FIXED_SHARE, for managing resource allocation among virtual machines.
This configuration is exposed via the topology JSON specification to allow users to experiment with the effect of these different policies.

A new test case validates the correct behavior of the EQUAL_SHARE distribution policy.
Adds flow distribution policies for CPU and GPU resources, including EqualShare and FixedShare, to optimize resource allocation.

Also includes test cases for the different distribution policies.
Introduces support for specifying GPU virtualization overhead models in the topology configuration.

This enhancement enables users to simulate the performance impact of virtualization on GPU resources, including:
- No overhead
- Constant overhead: A fixed percentage overhead.
- Share-based overhead: Overhead is proportional to the number of VMs.

Adds corresponding test cases to ensure the correct application of different overhead models.
@noleu noleu force-pushed the feat/virtualization-overhead branch from 963b1f2 to 7904fca Compare July 15, 2025 14:24
@DanteNiewenhuis DanteNiewenhuis merged commit 089c449 into atlarge-research:master Jul 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants