Skip to content

Updated FilterScheduler for performance#371

Merged
DanteNiewenhuis merged 3 commits into
atlarge-research:masterfrom
DanteNiewenhuis:scheduler-update
Sep 25, 2025
Merged

Updated FilterScheduler for performance#371
DanteNiewenhuis merged 3 commits into
atlarge-research:masterfrom
DanteNiewenhuis:scheduler-update

Conversation

@DanteNiewenhuis

@DanteNiewenhuis DanteNiewenhuis commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Summary

Updated the FilterScheduler to reduce redundant operations.

Implementation Notes ⚒️

The old implementation of FilterScheduler took all Hosts, filtered them, and sorted them.
However, in most cases only a few different types of hosts are actually used by a data center.
This means we can check only one of the hosts of each type instead of testing them all.

External Dependencies 🍀

N / A

Breaking API Changes ⚠️

N / A

Simply specify none (N/A) if not applicable.

@codecov

codecov Bot commented Sep 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.60976% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.41%. Comparing base (e84bb56) to head (a2d120a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ndc/compute/simulator/scheduler/FilterScheduler.kt 73.07% 3 Missing and 4 partials ⚠️
...mulator/scheduler/timeshift/MemorizingTimeshift.kt 0.00% 1 Missing ⚠️
...imulator/scheduler/timeshift/TimeshiftScheduler.kt 0.00% 1 Missing ⚠️
.../main/kotlin/org/opendc/web/runner/OpenDCRunner.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #371      +/-   ##
============================================
+ Coverage     57.36%   57.41%   +0.04%     
  Complexity        1        1              
============================================
  Files           335      335              
  Lines         10980    11013      +33     
  Branches       1021     1030       +9     
============================================
+ Hits           6299     6323      +24     
- Misses         4329     4334       +5     
- Partials        352      356       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DanteNiewenhuis DanteNiewenhuis merged commit 21ff6b0 into atlarge-research:master Sep 25, 2025
5 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the scheduler-update branch September 25, 2025 19:16
@DanteNiewenhuis DanteNiewenhuis self-assigned this Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant