Open
Conversation
aminya
force-pushed
the
only-merge-languages
branch
from
f178a53 to
0bc828f
Compare
To make #386 reviewable, that pr will be separated into many simpler prs. This is one of them. This first commit does the following: - update package.json - update package-lock.json using `./script/build` which also seems to update `apm/package-lock.json` - update packages/README.md - clone all language packages. Specifically: - `mkdir packages/language-<all of them>` - `cd packages/about` - For all languages: - `cd ../language-<>` - `git clone language-<>` - Move all files except `.git` from `language-<>/language-<>` to `language-<>` - delete `language-<>/language-<>` Since at first I accidentally updated `dependencies` then `packageDependencies`, it appears that since the versions of language-c, language-css, language-go, language-javascript, and language-sass don't match, `dependencies` was reset for those versions. [Those repos just happen to be precisely the ones that have tree-sitter v19](https://github.com/icecream17/atom-update-backlog/blob/main/Languages.md), (sans language-sass), which [currently breaks atom](atom#22129). So even though their repos are now in `packages`, **I've decided to not use them**. This is done by updating `packageDependencies` only for non-breaking languages.
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
aminya
force-pushed
the
only-merge-languages
branch
from
2c3e0e3 to
c5823d0
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#399 but merging it directly to master
To make #386 reviewable,
that pr will be separated into many simpler prs. This is one of them.
This first commit does the following:
./script/buildwhich also seems to updateapm/package-lock.jsonmkdir packages/language-<all of them>cd packages/aboutcd ../language-<>git clone language-<>.gitfromlanguage-<>/language-<>to
language-<>language-<>/language-<>Since at first I accidentally updated
dependenciesthenpackageDependencies, it appears that since the versions of language-c,language-css, language-go, language-javascript, and language-sass don't
match,
dependencieswas reset for those versions.Those repos just happen to be precisely the ones that have tree-sitter v19, (sans language-sass),
which currently breaks atom. So even though their repos are now
in
packages, I've decided to not use them.This is done by updating
packageDependenciesonly for non-breakinglanguages.⚛👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.