This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Show fast mode prompt on any project size#394
Merged
Conversation
rafeca
force-pushed
the
show-prompt-always
branch
from
15468da to
1e36f7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #378 to get more people opting in to the fast mode.
Context
Now that the fuzzy finder fast mode has been out for a couple of weeks in Atom v1.37 without any major issues, I’d like to open the gates a bit more to the feature to get more feedback from it before making it the default one.
The current plan is the following:
Doing this will give us much more signal about the fast mode on Atom v1.38 before enabling it by default (since currently we only have ~0.5% of users with
ripgrepenabled).Note: Due to our release cadence, I'll need to cherry-pick the new version of the
fuzzy-finderpackage on therelease-1.38branch, but that should be fine.