This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Remove realpathCache argument in fs.realpath#1269
Merged
Conversation
The cache was removed in Node 6 in favor of a faster native implementation. We're on Node 8 now.
|
Would it be clearer to simply omit the |
Contributor
Author
|
Yes, it would 😀. Mind was on autopilot there. |
Arcanemagus
approved these changes
Jul 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Node 6 removed the
cacheargument fromfs.realpathas it switched to a much faster native implementation. See nodejs/node#3594 for details. As Atom is now on Node 8, this argument is currently sitting there doing...nothing.Alternate Designs
None.
Benefits
Removal of a confusing argument from a bygone era.
Possible Drawbacks
None.
Applicable Issues
None, though I caught this when working on #1232.