Conversation
Contributor
Reviewer's GuideThis PR replaces pip-based dependency management and CI steps with uv-driven workflows by defining a dev group in pyproject.toml, removing legacy requirements files, updating CONTRIBUTING instructions, and migrating all GitHub Actions to use uv commands. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
uvto manage the package development.Changes include:
tests/requirements.txtanddocs/requirements.txtby adevgroup inpyproject.toml(which is automatically installed byuv)requirements.txtCONTRIBUTING.rstto useuv runfor testing and building docsuv buildinstead ofpython -m buildinside the Github Action to publish the packageSummary by Sourcery
Switch to
uvfor dependency and task management by consolidating dev dependencies inpyproject.toml, removing legacy requirements files, and updating CI workflows and documentation to useuvcommands.Enhancements:
devdependency group inpyproject.tomlto centralize development requirementsrequirements.txt,docs/requirements.txt, andtests/requirements.txtfilesCI:
uvin all GitHub Actions workflows and replace pip-based steps withuv sync,uv run,uv build, anduvxcommandsDocumentation:
CONTRIBUTING.rstand documentation instructions to useuvcommands instead of pip