Conversation
Contributor
Reviewer's GuideRefactor all type annotations to Python 3.9+ syntax by replacing typing.* generics and unions with built-in generics, PEP 585 collections, and PEP 604 union operators, and adjust imports for future annotations support. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @hagenw - I've reviewed your changes - here's some feedback:
- Replacing typing.Any with object changes the type‐checker semantics—object is more restrictive than Any, so double-check that this change is intentional.
- Ensure all new annotation names (Callable, Sequence, etc.) are imported from the correct modules (e.g. collections.abc) since typing imports were removed.
- Confirm that using built-in generics like list[str] and dict[str, object] aligns with your minimum Python and tooling versions so no unexpected compatibility issues arise.
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates syntax to Python >=3.9 by removing the use of
typing.Summary by Sourcery
Update type hints across core modules to use Python 3.9+ syntax, replacing typing module constructs with PEP 585 generics and the native union operator.
Enhancements: