Add signal for graceful shutdown of VMs#558
Merged
Merged
Conversation
mccormickt
commented
Jun 4, 2025
| // wait for all subscribers to drop | ||
| self.shutdown_broadcaster.closed().await; | ||
|
|
||
| if let Err(e) = self.cell_service.stop_all().await { |
Contributor
Author
There was a problem hiding this comment.
This seemed out of order. We should try and stop before freeing, I'd imagine?
dmah42
reviewed
Jun 4, 2025
mccormickt
force-pushed
the
graceful-vm
branch
2 times, most recently
from
5e81061 to
590b178
Compare
dmah42
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured we should have parity here between Cells and VMs.