Skip to content

update tests and ci starts from 5.4#61

Merged
harikt merged 2 commits into
auraphp:2.xfrom
harikt:unit-tests
Feb 5, 2022
Merged

update tests and ci starts from 5.4#61
harikt merged 2 commits into
auraphp:2.xfrom
harikt:unit-tests

Conversation

@harikt

@harikt harikt commented Feb 5, 2022

Copy link
Copy Markdown
Member

@koriym Aura.Html is supporting from 5.3 onwards.

We cannot support 5.3 tests, yoast/polyfill only starts with 5.4 .

So without a CI we cannot support 5.3 and probably as a convenience we should update the composer.json php version to 5.4.0 so that only php versions that support will get installed. So no accidental damage. That may be considered as a BC break though.

@codecov-commenter

codecov-commenter commented Feb 5, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (2.x@c128f28). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             2.x       #61   +/-   ##
=======================================
  Coverage       ?   100.00%           
  Complexity     ?       227           
=======================================
  Files          ?        42           
  Lines          ?       863           
  Branches       ?         0           
=======================================
  Hits           ?       863           
  Misses         ?         0           
  Partials       ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c128f28...720ae5a. Read the comment docs.

@harikt harikt requested a review from jakejohns February 5, 2022 10:16
@harikt

harikt commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

I am merging this. But please look into the comments on 5.3 and 5.4 .

@harikt harikt merged commit bdd0be7 into auraphp:2.x Feb 5, 2022
@harikt harikt deleted the unit-tests branch February 5, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants