feat(ui): persist category collapse state in sidebar

[jabloink]

partially addresses #539

Summary by CodeRabbit

• New Features

  • Collapsed category filters are now persisted across sessions and browser restarts.
  • Filter sidebar preferences automatically save and restore when you return to the application.

• Bug Fixes

  • Collapsed state is cleared when subcategory support is disabled to avoid inconsistent UI.
  • Stale/invalid collapsed entries are pruned when categories or subcategory support change.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Replaces local collapsed-categories state in FilterSidebar with a new persisted hook usePersistedCollapsedCategories, persisting to localStorage per instanceId. Adds logic to clear/prune collapsed entries when subcategory support or categories change.

Changes

Cohort / File(s)	Summary
New persistence hook web/src/hooks/usePersistedCollapsedCategories.ts	Adds usePersistedCollapsedCategories(instanceId) hook that initializes a Set<string> from localStorage key qui-collapsed-categories-${instanceId}, persists updates as JSON arrays, guards with isBrowser() and try/catch, and exposes [collapsedCategories, setCollapsedCategories] as const.
FilterSidebar component integration web/src/components/torrents/FilterSidebar.tsx	Replaces local useState<Set<string>> with usePersistedCollapsedCategories(instanceId). Tracks prevAllowSubcategories to clear collapsed state when subcategories are disabled and prunes stale category IDs when categories or subcategory support change.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

• Pay attention to localStorage read/write try/catch coverage and error logs in usePersistedCollapsedCategories.ts
• Verify effect dependency arrays and prevAllowSubcategories handling in FilterSidebar.tsx
• Confirm correct serialization/deserialization between Set<string> and JSON array and absence of stale closures

Possibly related PRs

• fix(torrents): tighten filter sidebar hover feedback #518 — Related changes to FilterSidebar.tsx and category/subcategory handling; overlaps in category rendering and state management.
• fix(web): indent subcategories in SetCategoryDialog #636 — Introduces/propagates allowSubcategories flag and subcategory UI which the pruning/clear logic depends on.

Suggested labels

enhancement, web

Poem

🐰 I nibbled keys in localStorage light,
Saved every fold through day and night,
Categories tucked, no longer stray,
A tidy burrow where bits can stay,
Hooray — persistent hops delight!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: implementing persistence for the category collapse state in the sidebar component.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c96d3e3 and ea23462.

📒 Files selected for processing (1)

• web/src/hooks/usePersistedCollapsedCategories.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• web/src/hooks/usePersistedCollapsedCategories.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

web/src/components/torrents/FilterSidebar.tsx (1)

1420-1452: Subcategory transition handling and stale collapsed-category cleanup are well thought out

Tracking prevAllowSubcategories to only clear collapsedCategories on enabled → disabled transitions avoids surprising resets on initial mount or toggling the feature on. The stale-entry cleanup effect also correctly:

• No-ops when there are no categories or no collapsed entries.
• Recomputes a valid-name set from categories and only mutates state when at least one entry is stale, preventing render loops.

Given allowSubcategories/subcategoriesEnabled are equivalent, this should behave as intended across capability and preference changes. If you want to tighten things further, you could optionally consolidate to a single boolean to reduce mental overhead, but that’s not required for correctness.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdf807e and c96d3e3.

📒 Files selected for processing (2)

• web/src/components/torrents/FilterSidebar.tsx (3 hunks)
• web/src/hooks/usePersistedCollapsedCategories.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

web/src/components/torrents/FilterSidebar.tsx (1)

web/src/hooks/usePersistedCollapsedCategories.ts (1)

• usePersistedCollapsedCategories (8-53)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run tests

🔇 Additional comments (1)

web/src/components/torrents/FilterSidebar.tsx (1)

36-36: Instance-scoped persistence wiring for collapsedCategories looks good

Using usePersistedCollapsedCategories(instanceId) and an instance-specific key keeps collapsed state correctly scoped per instance while preserving the existing Set<string> API for CategoryTree and toggle handlers. I don’t see behavioral regressions relative to the prior in-component state.

Also applies to: 282-282