Draft
Conversation
benjamc
commented
Jan 5, 2026
| instance_data = yaml.safe_load(f) | ||
| print(instance_data) | ||
| self.config["instance_set"] = { | ||
| 0: instance_data["task_ids"] |
Collaborator
There was a problem hiding this comment.
Required by the abstract env:
DACBench/dacbench/abstract_env.py
Line 30 in fc5963c
Contributor
Author
There was a problem hiding this comment.
then the instance set should be the product of task ids and seeds.
internally we don't use it anyway, but that would be the correct setting, can you please change that?
might be relevant for stuff like curriculum learning
4 tasks
Collaborator
|
…anch Add comprehensive tests for action spaces, instance selectors, and features to bring the dacboenv branch to parity with feat/dacboenv-integrated. - TestDACBOEnv: add make_env(**overrides) helper and new tests for full episode rollout, bucket/step/continuousstep/AcqFunction action spaces, WEITempoRL validation, and observation key subsetting - TestInstanceSelectors: add round-robin and random instance selector tests - TestFeatures: add knn_entropy, exploration_tsd, and calculate_ubr tests All tests use dacboenv.* import paths (external package). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.