Try and let processes exit on their own instead of calling process.exit();#241
Try and let processes exit on their own instead of calling process.exit();#241jamestalmage wants to merge 2 commits intoavajs:masterfrom
Conversation
|
Still failing. I've had enough, let's just remove Node.js 0.10 from AppVeyor. It's already tested on Linux. ? |
|
I begrudgingly agree. Very disappointed this is the route we have to take: http://help.appveyor.com/discussions/problems/1352-output-of-commands-is-often-trimmed mapnik/node-mapnik#257 (comment) http://help.appveyor.com/discussions/problems/1257-console-output-suppressed |
|
Here is the core issue: nodejs/node-v0.x-archive#7196 The fix needs to be back-ported to the Node @sindresorhus Do you know anybody working on node that could push that along? This will impact our ability to provide TAP output on Node 0.10 / Windows. If we can't get this fixed upstream, we should at least do our users the courtesy of officially NOT supporting it, and documenting the lack of support. Something along the lines of "We support all LTS versions of Node, with the exception of |
Yeah, let's just document it. I honestly couldn't care less about an ancient Node.js version on Windows. Most people test on Travis anyways. I think we've wasted more than enough time dealing with this. |
|
There's https://github.com/cowboy/node-exit, but |
I am perfectly fine leaving it at that.
I don't think |
|
@jamestalmage you could just do a PR on node with that backport, targeting the |
See discussion on #239