Open
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #478 +/- ##
===========================================
+ Coverage 79.87% 80.41% +0.54%
===========================================
Files 176 177 +1
Lines 2216 2242 +26
===========================================
+ Hits 1770 1803 +33
+ Misses 446 439 -7
Continue to review full report at Codecov.
|
24f8fad to
226e1b3
Compare
If an order has promotion applied to it, then if any of the line items are touched(updated, removed) or a new line item is added, promotion associated with it needs to be re-evaluated so that right adjustments are present for the order. This change - Adds a module to handle promotion re-evaluation whenever line items of an order are added, removed or updated. - The ineligible adjustments for an order are now removed so that only eligible adjustments are present.
226e1b3 to
f024b0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
If an order has promotion applied to it, then if any of the line items
are touched(updated, removed) or a new line item is added, promotion
associated with it needs to be re-evaluated so that right adjustments
are present for the order.
This change addresses the need by:
This change
of an order are added, removed or updated.
only eligible adjustments are present.
[delivers #163001984]
Checklist
credoand compile-time warnings.