Conversation
reesscot
approved these changes
Jul 22, 2021
elorzafe
approved these changes
Jul 22, 2021
Contributor
elorzafe
left a comment
There was a problem hiding this comment.
Thanks @hkjpotato !! 🌮 🎉 🎖️
Codecov Report
@@ Coverage Diff @@
## main #8626 +/- ##
==========================================
+ Coverage 77.79% 77.80% +0.01%
==========================================
Files 240 240
Lines 17121 17121
Branches 3650 3650
==========================================
+ Hits 13319 13321 +2
+ Misses 3677 3675 -2
Partials 125 125
Continue to review full report at Codecov.
|
Contributor
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
upgrade crypto-js to include the bundle size fix brix/crypto-js#364
This fixes #7570
Comparison of bundle sizes
Because crypto-js has upgraded, I will close the previous PR on deprecating crypto-js. Also create an internal TT for further investigation.
Issue #, if available
#7570
Description of how you validated changes
crypto-jsupgrade.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.